Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useMutation also reset internal state on reset #10931

Merged
merged 5 commits into from
Nov 10, 2023
Merged

useMutation also reset internal state on reset #10931

merged 5 commits into from
Nov 10, 2023
+95 −3

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented May 30, 2023 •
edited
Loading

Fixes #10927

This still needs tests, but I'm already opening a PR so we can have a PR release and have them try it out.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 5b6b1fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.08 KB (+0.05% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.54 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 42.03 KB (+0.05% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.6 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.27 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.22 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.21 KB (0%)
import { useQuery } from "dist/react/index.js" 4.28 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.1 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.59 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.41 KB (0%)
import { useMutation } from "dist/react/index.js" 2.55 KB (+0.7% 🔺)
import { useMutation } from "dist/react/index.js" (production) 2.54 KB (+0.62% 🔺)
import { useSubscription } from "dist/react/index.js" 2.24 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.2 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 4.62 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.05 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.14 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.56 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.94 KB (0%)
import { useFragment } from "dist/react/index.js" 2.09 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.04 KB (0%)

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/[email protected].

@phryneas phryneas mentioned this pull request May 30, 2023
Closed
@phryneas phryneas self-assigned this Jun 12, 2023
@phryneas phryneas marked this pull request as ready for review November 9, 2023 10:54
@phryneas
Copy link
Member Author

phryneas commented Nov 9, 2023

Lost track of this one a bit, I've added tests now - let's get it reviewed and shipped :)

jerelmiller
jerelmiller approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@phryneas phryneas merged commit e5acf91 into main Nov 10, 2023
23 checks passed
@phryneas phryneas deleted the pr/fix-10927 branch November 10, 2023 10:29
This was referenced Nov 8, 2023
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jerelmiller jerelmiller jerelmiller approved these changes

@alessbell alessbell Awaiting requested review from alessbell

Assignees

@phryneas phryneas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ongoing mutation results are not ignored when calling MutationResult.reset()
2 participants
@phryneas @jerelmiller